Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse old session by setting session_id #307

Merged
merged 2 commits into from
May 25, 2017
Merged

Conversation

vitstradal
Copy link
Contributor

Sometimes it is useful to use existing session in selenium, like:

my $driver = Selenium::Driver::Remote->new({session_id => $sess_id}); 

So this patch check if user want connect to existing session and skips creating new one.

@gempesaw
Copy link
Collaborator

Oh, this seems like a pretty good idea. Are those changes all it takes to make it work? Are you interested in adding tests for this ?

@vitstradal
Copy link
Contributor Author

Yes, this is all. I tried create some tests, but not sure if it is enough. I'm not familiar with creating mock files.

@gempesaw gempesaw merged commit 945c27c into teodesian:master May 25, 2017
@gempesaw
Copy link
Collaborator

thanks!

gempesaw added a commit that referenced this pull request May 25, 2017
        [BUG FIXES]
        - Shim use of name as find method for geckodriver
        - Start up geckodriver/binary Firefox properly
        - #309, #310: @SysPete: Fix issues with dependencies

        [NEW FEATURES]
        - #307: @vitstradal: Re-use an existing session
gempesaw added a commit that referenced this pull request May 25, 2017
        [BUG FIXES]
        - Shim use of name as find method for geckodriver
        - Start up geckodriver/binary Firefox properly
        - #309, #310: @SysPete: Fix issues with dependencies
        - #313, #312: @lukec: Handle saucelabs redirect during session create

        [NEW FEATURES]
        - #307: @vitstradal: Re-use an existing session
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants