Parallel stream

[reubot]

This pull speeds up comparison by using a parallelStream.

[tenzap]

Since this is just a fork of the main repo what do you expect? Should I merge this so that it enters my pull request CUTR-at-USF#62 ?

Can I squash the commits or do you prefer them to be separate?

Are you confident that it works fine? I'm not sure I have enough knowledge to evaluate it.

[reubot]

Since this is just a fork of the main repo what do you expect? Should I merge this so that it enters my pull request CUTR-at-USF#62 ?

This would be good since we are waiting on your merge to enter upstream

Can I squash the commits or do you prefer them to be separate?

Up to you.

Are you confident that it works fine? I'm not sure I have enough knowledge to evaluate it.

Yes, I have backported this from one of my dev branches. it greatly speeds up comparison time by wrapping comparebusstops in a parrallelstream:

before

tags = 14612
Existing Nodes = 14612
New Nodes = 13018
reportkeys 12897reportIDs 0
relation tags = 399
tags = 399
Reading GTFS routes from modify and noupload sets...
java.time.format.DateTimeParseException: Text '24:41:00' could not be parsed: Invalid value for HourOfDay (valid values 0 - 23): 24 [Ljava.lang.StackTraceElement;@758ad125
Done...!!
Completed in 250.457seconds
GTFSstops 13018 report:13018 upload:380 modify:12983 delete:0
Categories UPLOAD_CONFLICT:259 UPLOAD_NO_CONFLICT:121 MODIFY:12411 NOTHING_NEW:227

after

tags = 14612
Existing Nodes = 14612
New Nodes = 13018
reportkeys 12886reportIDs 0
relation tags = 399
tags = 399
Reading GTFS routes from modify and noupload sets...
java.time.format.DateTimeParseException: Text '24:41:00' could not be parsed: Invalid value for HourOfDay (valid values 0 - 23): 24 [Ljava.lang.StackTraceElement;@1d931b80
Done...!!
Completed in 47.991seconds
GTFSstops 13018 report:13018 upload:380 modify:13163 delete:0
Categories UPLOAD_CONFLICT:248 UPLOAD_NO_CONFLICT:132 MODIFY:12411 NOTHING_NEW:227

A reduction of over 3 minutes!

[reubot]

I got in touch with @barbeau on LinkedIn: he sent this reply:

I left USF around 2 years ago. No one is currently maintaining the repository. I just talked to the admins at USF and had them archive the organization to make this clear publicly.

So you may as well merge this and we will need to decide which to make thenew origin fork.

[tenzap]

Thanks for the update.
I don't plan doing more work on this, so feel free to fork upstream and merge my PR to the new fork.

[tenzap]

Maybe if you are interested in being the new maintainer, the repo could be transferred to you, or you could be granted permission on the repo? That would avoid creating a fork.

[reubot]

I'll update the the osm docs to make mine the referenced fork.