Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline_lifetime field to enable alert end nodes. #6858

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions tfx/components/statistics_gen/executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
from absl import logging
import tensorflow_data_validation as tfdv
from tensorflow_data_validation.statistics import stats_options as options
from tensorflow_data_validation.utils import dashboard_util
from tfx import types
from tfx.components.statistics_gen import stats_artifact_utils
from tfx.components.util import examples_utils
Expand All @@ -27,7 +28,6 @@
from tfx.types import standard_component_specs
from tfx.utils import io_utils
from tfx.utils import json_utils
from tfx.utils import stats_utils


# Default file name for stats generated.
Expand Down Expand Up @@ -151,8 +151,7 @@ def Do(

try:
statistics_artifact.set_string_custom_property(
STATS_DASHBOARD_LINK,
stats_utils.generate_stats_dashboard_link(statistics_artifact),
STATS_DASHBOARD_LINK, dashboard_util.generate_stats_dashboard_link()
)
except Exception as e: # pylint: disable=broad-except
# log on failures to not bring down Statsgen jobs
Expand Down
5 changes: 5 additions & 0 deletions tfx/proto/orchestration/pipeline.proto
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,11 @@ message NodeExecutionOptions {
// If set then the node this NodeExecutionOptions belongs to marks the end
// of some lifetime.
string lifetime_start = 1;
// If True then the node this NodeExecutionOptions belongs to will execute
// when the pipeline is considered "finalized". Noted that the node will
// not have a start node and the node will always be triggered when the
// pipeline is finalized.
bool pipeline_lifetime = 2;
}
}

Expand Down
21 changes: 0 additions & 21 deletions tfx/utils/stats_utils.py

This file was deleted.