Orchestration/Kubeflow - Removed the use of undocumented KFP compiler API #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See tensorflow#30 (comment) The KFP documentation clearly says that the pipeline function must be decorated with `@pipeline` decorator. It's even mentioned in the `compile` function documentation: https://github.com/kubeflow/pipelines/blob/086d4763d9f163acdeb423bc2bc49ab470442a92/sdk/python/kfp/compiler/compiler.py#L636 Running `compile` without having the function decorated https://github.com/tensorflow/tfx/blob/d9f87b9b03ab8bb98653b8a96d5bf952bc22b2b7/tfx/orchestration/kubeflow/runner.py#L125 will raise error: https://github.com/kubeflow/pipelines/blob/086d4763d9f163acdeb423bc2bc49ab470442a92/sdk/python/kfp/compiler/compiler.py#L578 `'Please use a function with @dsl.pipeline decorator.'`. For some reason this documented behavior was circumvented by a hack that used an undocumented function that should be a part of internal compiler API. This PR fixes this issue.
Merged
Ark-kun
changed the title
|
/cc @neuromage |
|
Gentle ping |
|
Ping. |
neuromage
reviewed
Apr 19, 2019
|
JFYI: The decorator is not required by the KFP compiler since v0.1.17 (last week release). Also: is syntactic sugar for |
neuromage
approved these changes
Apr 23, 2019
tfx-copybara
pushed a commit
that referenced
this pull request
Apr 23, 2019
PiperOrigin-RevId: 244882204
ruoyu90
pushed a commit
to ruoyu90/tfx
that referenced
this pull request
Aug 28, 2019
This fix update the SIG IO's release process so that anyone could help the release for SIG IO. Signed-off-by: Yong Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #30 (comment)
The KFP documentation clearly says that the pipeline function must be decorated with
@pipelinedecorator. It's even mentioned in thecompilefunction documentation: https://github.com/kubeflow/pipelines/blob/086d4763d9f163acdeb423bc2bc49ab470442a92/sdk/python/kfp/compiler/compiler.py#L636Running
Compiler().compile(...)without having the function decorated will raise error: https://github.com/kubeflow/pipelines/blob/086d4763d9f163acdeb423bc2bc49ab470442a92/sdk/python/kfp/compiler/compiler.py#L578'Please use a function with @dsl.pipeline decorator.'.For some reason this documented behavior was circumvented by a hack that used an undocumented function that should be a part of internal compiler API.
This has triggered the #30 issue when the internal compiler API was changed by the KFP team.
This PR fixes this issue.