Skip to content

Commit

Permalink
Introduces a temporary cap for Cython because new alpha releases of C…
Browse files Browse the repository at this point in the history
…ython doesn't work with pycocotools which is installed by 'tensorflow-ranking'.

Because Cython is already a dependency of tensorflow-ranking, this change doesn't add a new dependency.

And we need to install Cython separately in order to succeed the pycocotools installation. It seems like an issue in pycocotools or pip, but added a workaround temporarily.

PiperOrigin-RevId: 449927854
  • Loading branch information
jiyongjung authored and tfx-copybara committed May 20, 2022
1 parent a207d12 commit 517441d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip wheel
# TODO(b/232490018): Cython need to be installed separately to build pycocotools.
python -m pip install Cython -c ./test_constraints.txt
TFX_DEPENDENCY_SELECTOR=NIGHTLY pip install -c ./test_constraints.txt --extra-index-url https://pypi-nightly.tensorflow.org/simple --pre --editable .[all]
- name: Run unit tests
Expand Down
3 changes: 3 additions & 0 deletions test_constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@

# TODO(b/220800338): Workaround for markupsafe.
markupsafe<2.1.0

# TODO(b/232490018) Remove pinned Cython after pycocotools issue resolved.
Cython<1

0 comments on commit 517441d

Please sign in to comment.