add tag to shared object #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Nice idea. |
Draft
rose-rong-liu
approved these changes
Aug 6, 2020
SherylLuo
approved these changes
Aug 6, 2020
|
this was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the shared object handle to store a
tagwith cached objects. By default,shared.acquirewill keep a reference until it is garbage collected. By specifying a tag, the user can force cache eviction if the tag passed with acquire doesn't match the tag stored with the cached object.This PR does not change public APIs but it is a prerequisite for the model streaming api where
RunInferencemay need to force cache eviction of models loaded in memory.Currently,
shared.pyis migrating to Beam core howeverRunInferencestill depends on the tfx-bsl version. Eventually this PR will also need to be reflected in the Beam version ofshared.py.