build(bazel): provide means of excluding whl_test locally #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark whl_test as size "large", so that it, and other tests of a similar size, can be excluded with the --test_size_filters option. For even more convenience, provide a hook for developers to add localy .bazlerc-style defaults and configurations in $root/bazelrc.local and ../$root/bazelrc.local. This gives a convenient means of explicitly excluding whl_test during local, incremental development runs of `bazel test ...`, while not surprising users who don't opt in, and without affecting CI. whl_test's cached result is invalidated, and the test rerun, following most git activity, because the git hash appears in the Python package's version number. This combined with its long runtime and network dependency makes it a nuisance when running `bazel test ...` incrementally during development. Of course, this test should be allowed to run when developing changes that affect the package, before pushing commits to main, and in CI.
suleshahid
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark whl_test as size "large", so that it, and other tests of a
similar size, can be excluded with the --test_size_filters
option.
For even more convenience, provide a hook for developers to add
local .bazlerc-style defaults and configurations in
$root/bazelrc.local and ../$root/bazelrc.local.
This gives a convenient means of explicitly excluding whl_test
during local, incremental development runs of
bazel test ...,while not surprising users who don't opt in, and without
affecting CI.
whl_test's cached result is invalidated, and the test rerun,
following most git activity, because the git hash appears in the
Python package's version number. This combined with its long
runtime and network dependency makes it a nuisance when running
bazel test ...incrementally during development. Of course,this test be run when developing changes that affect the package,
before pushing commits to main, and in CI.
BUG=see description