build(bazel): add --//:with_compression build setting #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a --//:with_compression user-defined build setting and a corresponding configuration setting.
|
Just to add some more info to the PR, could you add to the PR description the equivalent MAKE flag/define this will be enabling. |
|
cortex-m failures from this? seems different error from the other bug, but not sure why |
Description updated. |
These look like unrelated, temporary network failures when downloading third party dependences (when driven by Make, not Bazel). |
suleshahid
approved these changes
Nov 20, 2024
|
@Mergifyio refresh |
✅ Pull request refreshed |
✅ Pull request refreshed |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio refresh |
✅ Pull request refreshed |
✅ Pull request refreshed |
suleshahid
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a --//:with_compression user-defined build setting and a
corresponding configuration setting.
Among other things, this will be used by Bazel in the future to
define the preprocessor macro USE_TFLM_COMPRESSION,
turning on conditional compilation of the compression feature.
BUG=#2636