Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce prod porting #2532

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Conversation

Evanok
Copy link

@Evanok Evanok commented Apr 1, 2024

This PR is part of the work to port operator REDUCE_PROD from lite to micro,
as tracked in this issue #2527

Copy link
Contributor

"This PR is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

@github-actions github-actions bot added the Stale label May 13, 2024
Copy link
Contributor

"This PR is being closed because it has been marked as
stale for 5 days with no further activity."

@github-actions github-actions bot closed this May 19, 2024
@yair-ehrenwald
Copy link
Contributor

Any chance of this being reopened and merged in? Seems like the work has already been done and reduce_prod availability is pretty important for some of our models.

@yair-ehrenwald
Copy link
Contributor

I'm hopeful, so reopening :)

@Evanok
Copy link
Author

Evanok commented Oct 28, 2024

Any chance of this being reopened and merged in? Seems like the work has already been done and reduce_prod availability is pretty important for some of our models.

Feel free to finish the job.
I currently don't have the time to finish this job. At the end I did not use Tflite for my project.

In theory you just need to write relevant test to validate the change. During my test I started to write some test but I was even not sure of the expected result.

@yair-ehrenwald
Copy link
Contributor

Any chance of this being reopened and merged in? Seems like the work has already been done and reduce_prod availability is pretty important for some of our models.

Feel free to finish the job. I currently don't have the time to finish this job. At the end I did not use Tflite for my project.

In theory you just need to write relevant test to validate the change. During my test I started to write some test but I was even not sure of the expected result.

I'll take a look and see if I can wrap it up, thanks :)

Copy link
Contributor

github-actions bot commented Dec 8, 2024

"This PR is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants