[wasm] Add MaxPoolWithArgmax kernel #7673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linchenn
approved these changes
May 9, 2023
mattsoulanille
approved these changes
May 10, 2023
Comment on lines
+104
to
+123
| switch (dtype) { | ||
| case DType::float32: | ||
| MaxPoolWithArgmaxImpl(x_info.f32(), pooled_info.f32_write(), | ||
| indexes_info.i32_write(), include_batch_index, | ||
| pool_info); | ||
| break; | ||
| case DType::int32: | ||
| MaxPoolWithArgmaxImpl(x_info.i32(), pooled_info.i32_write(), | ||
| indexes_info.i32_write(), include_batch_index, | ||
| pool_info); | ||
| break; | ||
| case DType::boolean: | ||
| MaxPoolWithArgmaxImpl(x_info.b(), pooled_info.b_write(), | ||
| indexes_info.i32_write(), include_batch_index, | ||
| pool_info); | ||
| break; | ||
| default: | ||
| util::warn("MaxPoolWithArgmax for tensor id failed. Unknown dtype %d", | ||
| x_id, dtype); | ||
| } |
There was a problem hiding this comment.
I sort of wonder if this dtype switch could be a macro, but that would probably be unreadable and prone to bugs.
There was a problem hiding this comment.
Yes, and that's part of the wasm-backend productionization work. Currently tensor type check in wasm kernels are not comprehensive and rely on switch branches everywhere. I will replace all of them with some type introspection in the future and correctly throw errors when unsupported. But before that I'd just use the old fashion so I can better find out where needs to be fixed when applying large scale changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick implementation based on existing pool3d library. Will look into utilizing xnnpack in the future.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.