[wasm] Add Mod kernel #7670
Merged
[wasm] Add Mod kernel #7670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linchenn
approved these changes
May 9, 2023
mattsoulanille
approved these changes
May 10, 2023
Comment on lines
+30
to
+46
| template <typename T> | ||
| inline T ModInt(T a, T b) { | ||
| T rem = a % b; | ||
| if ((a < 0 && b < 0) || (a >= 0 && b >= 0)) { | ||
| return rem; | ||
| } | ||
| return (rem + b) % b; | ||
| } | ||
|
|
||
| template <typename T> | ||
| inline T ModFloat(T a, T b) { | ||
| T rem = std::fmod(a, b); | ||
| if ((a < 0 && b < 0) || (a >= 0 && b >= 0)) { | ||
| return rem; | ||
| } | ||
| return std::fmod(rem + b, b); | ||
| } |
There was a problem hiding this comment.
Nit: Should these be templates if they're specifically for int and float?
There was a problem hiding this comment.
It's just 3 extra lines of code. Let's keep it for simplicity.
Closed
This was referenced May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch from #4236
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.