Webgl backend for bitwise AND API #7654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunnienc
requested changes
May 4, 2023
| program = new BinaryOpProgram(BITWISEAND, a.shape, b.shape); | ||
| } | ||
|
|
||
| return webglBackend.runWebGLProgram(program, [a, b], $dtype); |
There was a problem hiding this comment.
Maybe wrap it with binaryKernelFunc like tfjs-backend-webgl/kernels/Add.ts to utilize the CPU forward implementation?
There was a problem hiding this comment.
We have to check webgl version for this, which is different from other binary ops. If using binaryKernelFunc, then we either have to change a lot for binaryKernelFunc or make a wrapper to call binaryKernelFunc.
There was a problem hiding this comment.
Thanks! Implemented the CPU forward logic in the function.
Linchenn
requested changes
May 4, 2023
fengwuyao
force-pushed
the
addGLbackend
branch
2 times, most recently
from
b55d5de
to
40a678c
Compare
chunnienc
reviewed
May 4, 2023
Linchenn
approved these changes
May 4, 2023
chunnienc
reviewed
May 4, 2023
| `Unsupported webgl version. Current webgl version: ${versionNumber}`); | ||
| } | ||
|
|
||
| // The type of a and b are ensured to be `int` in core, therefore no need to |
chunnienc
approved these changes
May 4, 2023
fengwuyao
force-pushed
the
addGLbackend
branch
2 times, most recently
from
2f10aa1
to
90b51bf
Compare
pyu10055
approved these changes
May 4, 2023
chunnienc
reviewed
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement webgl kernels for bitwise
ANDAPIyarn testundertfjs-backend-webglTo see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.