Remove duplicate Prod and SparseToDense ops from converter #7649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsoulanille
commented
May 4, 2023
Comment on lines
+241
to
+246
| }, | ||
| { | ||
| "tfName": "T", | ||
| "name": "dtype", | ||
| "type": "dtype", | ||
| "notSupported": true |
There was a problem hiding this comment.
@pyu10055 do you know what this 'T' attribute is for?
There was a problem hiding this comment.
that is for the supported dtype, we don't actually look at those right now
pyu10055
approved these changes
May 4, 2023
Comment on lines
+241
to
+246
| }, | ||
| { | ||
| "tfName": "T", | ||
| "name": "dtype", | ||
| "type": "dtype", | ||
| "notSupported": true |
There was a problem hiding this comment.
that is for the supported dtype, we don't actually look at those right now
chunnienc
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7648
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.