Add browser tests for CPU backend #7633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With these changes, when I ran |
This has been fixed. Thanks Matt! |
mattsoulanille
approved these changes
Apr 28, 2023
tfjs-backend-cpu/BUILD.bazel
Outdated
| args = [], | ||
| browsers = [], | ||
| headless = False, | ||
| presubmit_browsers = [] |
There was a problem hiding this comment.
Nit: If this is empty, these tests won't run in presubmits. Is that intentional? Do the tests only work with headless = False?
There was a problem hiding this comment.
Done. Thanks! Also removed core tests from this test target.
pyu10055
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds browser test target for CPU backend. The test target does not include tests in Core, but the test target is added to nightly and presubmit tests.
Only added "bs_chrome_mac" for nightly and presubmit tests, because the CPU tests do not heavily relay on the platform.
Currently, CPU backend only has Node.js tests. We could provide browser tests for CPU backend, even though it does not need to be integrated into CI and nightly tests. eg. this would be helpful for Draw API tests for CPU backend.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.