webgpu: Fix a bug in softmax #7607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hujiajie Please take a look, thanks. |
gyagp
approved these changes
Apr 20, 2023
xhcao
approved these changes
Apr 20, 2023
mattsoulanille
added a commit
that referenced
this pull request
Apr 24, 2023
* webgpu: Fix a bug in softmax (#7607) * Avoid allocating a large arraybuffer when loading weights (#7598) The loadWeights function loads weights in 4MB chunks and then concatenates them into a single large ArrayBuffer. That ArrayBuffer is used for splitting the weights data back up into tensors. Allocating large ArrayBuffers (3.5GB) can be unstable on Chrome, so this PR avoids this allocation, instead slicing the weights out of the chunks manually. The implementation wraps the array of weights (stored as ArrayBuffer[]) in a new CompositeArrayBuffer class. This class implements slice by copying the desired range out of the buffer(s) that it overlaps with. * Support using a list of ArrayBuffers as model weight data * Avoid 'Array.flat()' * Simplify some of the tests * Do not export 'CompositeArrayBuffer' from tfjs-core * Update doc for weightData * Fix tfjs-node * Remove unused import --------- Co-authored-by: Jiajia Qin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is