[e2e] Fix golden file test indexing nonexistent tensor #7527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `.toEqual(jasmine.anything())` instead of `.not.toEqual(null)` to catch both `null` and `undefined`. Use `model.outputs.map(output => output.name)` instead of `model.outputNodes` to get the output node name without the numerical index.
chunnienc
approved these changes
Mar 28, 2023
I verified that |
|
Just want to check if the tests without node name fix fail after we check the nullity with |
pyu10055
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 2 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
.toEqual(jasmine.anything())instead of.not.toEqual(null)to catch bothnullandundefined.Use
model.outputs.map(output => output.name)instead ofmodel.outputNodesto get the output node name without the numerical index.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is