Improve assertAndGetBroadcastShape #7413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunnienc
requested changes
Feb 24, 2023
chunnienc
approved these changes
Feb 24, 2023
mattsoulanille
approved these changes
Feb 24, 2023
Linchenn
commented
Feb 24, 2023
There was a problem hiding this comment.
Yes, even if I remove reverse(), this is still 20% faster than push() way.
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @chunnienc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://jsbench.me/bmlehvit9v/1, push is far faster than unshift.
assertAndGetBroadcastShape2is after this PR.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is