Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Array.at usage #7409

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Remove Array.at usage #7409

merged 1 commit into from
Feb 22, 2023

Conversation

chunnienc
Copy link
Collaborator

@chunnienc chunnienc commented Feb 22, 2023

Array.at(..) is not supported in Mac.
Behavior change: originally the tensor name lookup is done by nodeNames.slice(start)[0], which returns the first element when start < -nodeNames.length. It now returns undefined.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chunnienc chunnienc merged commit 47a21a7 into tensorflow:master Feb 22, 2023
@chunnienc chunnienc deleted the fix-array-at branch February 22, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants