SharedArrayBuffer is not GPU data

[axinging]

Bug: #7343

TODO: Add test case for ShardArrayBuffer.

describeWithFlags('tensor from ShardArrayBuffer', ALL_ENVS, () => {
  it('float32 tensor from ShardArrayBuffer', async () => {
    let length = 4;
    // ReferenceError: SharedArrayBuffer is not defined.
    let sharedFloats = new Float32Array(new SharedArrayBuffer(length * 4));
    let expected = [];
    for (let i = 0; i < length; i++) {
      sharedFloats[i] = i;
      expected[i] = i;
    }
    const a = tf.tensor(sharedFloats);
    tf.test_util.expectArraysEqual(await a.data(), expected);
  });
});

---

This change is 

[Linchenn]

Great catch, thanks you!

I am considering, rather than excluding cases, what about we do checks like:?

if ('texture' in values && values.texture instanceof WebGLTexture) {
  return GPUDataType.WebGL;
} else if ( 'buffer' in values && values.buffer instanceof GPUBuffer) {
...
}

[axinging]

@Linchenn, if use 'buffer' in values && values.buffer instanceof GPUBuffer, some bots targets (cpu, wasm...) will complain: ReferenceError: GPUBuffer is not defined.

BTW, I am trying to add a test case 'tensor from ShardArrayBuffer', however, chrome complains 'ReferenceError: SharedArrayBuffer is not defined.' It seems 'yarn karma start' doesn't support SharedArrayBuffer . This can be workaround by https://github.com/Honry/webnn-samples/blob/tflite-deeplab/server.js.

@qjia7 @xhcao @haoyunfeix @gyagp , PTAL

[Linchenn]

It seems that 'buffer' in values is hard to distinguish WebGPUData from other objects with buffer key.

Could we rename WebGPUData's buffer filed to something else? but it might have to change lots of codes. I am just providing a candidate idea.

[hujiajie]

What about this idiom (though I don't feel parenthesis is needed around the operand of typeof)?

[axinging]

Thanks, @hujiajie, it seems the bots turrn green.

@Linchenn , Could you please take another look?

[Linchenn]

Nice workaround. LGTM, thanks!

[mattsoulanille]

Sorry for the late review!

[mattsoulanille]

LGTM