[wasm] Add Dilation2D #7327
Merged
[wasm] Add Dilation2D #7327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linchenn
reviewed
Jan 31, 2023
| const {x, filter} = inputs; | ||
| const {strides, pad, dilations} = attrs; | ||
|
|
||
| if (x.dtype !== filter.dtype) { |
There was a problem hiding this comment.
Could we move this check to core? As I know, we typically do users' input check in core; otherwise the backends' behaviors could be different.
There was a problem hiding this comment.
This is intentional: our cpu and webgl backend can take different types and do the type cast automatically, while wasm backend is very hard to do that. Therefore this check is just here to make the wasm implementation easier.
The TF Dilation2D op also has this constraint that x and filter must have the same type, so it should be fine in terms of correctness. However, it will be a breaking change to TFJS if we move this check to core level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is