-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Add AvgPool3DGrad and MaxPool3DGrad kernels #7295
Conversation
a03638f
to
bb5c291
Compare
bb5c291
to
5fc4434
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great implementation, thanks!
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @chunnienc and @Linchenn)
tfjs-backend-wasm/src/cc/BUILD.bazel
line 514 at r1 (raw file):
tfjs_cc_library( name = "AvgPool3DGrad", srcs = ["kernels/AvgPool3D.cc"],
AvgPool3DGrad.cc ?
tfjs-backend-wasm/src/cc/kernels/MaxPool3DGrad.cc
line 89 at r1 (raw file):
}, /*filter_aggregate=*/ [](const std::pair<float, int>& data) { return data.second; });
I like reusing pooling for position computation, very nice
Done, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is