Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Add AvgPool3DGrad and MaxPool3DGrad kernels #7295

Merged
merged 19 commits into from
Jan 26, 2023

Conversation

chunnienc
Copy link
Collaborator

@chunnienc chunnienc commented Jan 21, 2023

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@chunnienc chunnienc force-pushed the wasm-pool3d-grad branch 2 times, most recently from a03638f to bb5c291 Compare January 23, 2023 04:49
@chunnienc chunnienc marked this pull request as ready for review January 24, 2023 23:51
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great implementation, thanks!

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @chunnienc and @Linchenn)


tfjs-backend-wasm/src/cc/BUILD.bazel line 514 at r1 (raw file):

tfjs_cc_library(
    name = "AvgPool3DGrad",
    srcs = ["kernels/AvgPool3D.cc"],

AvgPool3DGrad.cc ?


tfjs-backend-wasm/src/cc/kernels/MaxPool3DGrad.cc line 89 at r1 (raw file):

      },
      /*filter_aggregate=*/
      [](const std::pair<float, int>& data) { return data.second; });

I like reusing pooling for position computation, very nice

@chunnienc
Copy link
Collaborator Author

great implementation, thanks!

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @chunnienc and @Linchenn)

tfjs-backend-wasm/src/cc/BUILD.bazel line 514 at r1 (raw file):

tfjs_cc_library(
    name = "AvgPool3DGrad",
    srcs = ["kernels/AvgPool3D.cc"],

AvgPool3DGrad.cc ?

tfjs-backend-wasm/src/cc/kernels/MaxPool3DGrad.cc line 89 at r1 (raw file):

      },
      /*filter_aggregate=*/
      [](const std::pair<float, int>& data) { return data.second; });

I like reusing pooling for position computation, very nice

Done, thanks.

Copy link
Collaborator

@Linchenn Linchenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tfjs-backend-wasm/src/cc/pool3d_impl.h Show resolved Hide resolved
@chunnienc chunnienc merged commit 49d2746 into tensorflow:master Jan 26, 2023
@chunnienc chunnienc deleted the wasm-pool3d-grad branch January 26, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants