Debug converter python code with debugpy #7283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsoulanille
commented
Jan 17, 2023
| @@ -110,6 +110,12 @@ py_library( | |||
| deps = [requirement("packaging")], | |||
| ) | |||
|
|
|||
| py_library( | |||
There was a problem hiding this comment.
Note to reviewer: debugpy is already in google3, so this shouldn't break copybara.
chunnienc
approved these changes
Jan 17, 2023
pyu10055
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @Linchenn)
Linchenn
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for debugging tfjs-converter Bazel tests using debugpy in vscode. Support is not perfectly ergonomic yet, but it works and is much better than nothing.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is