Refactor python converter functions to not call each other #7281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linchenn
approved these changes
Jan 17, 2023
| @@ -323,7 +278,7 @@ def extract_weights(graph_def, | |||
| initializer_signature_def=initializer_signature_def, | |||
| resource_ids_maps=resource_ids_maps, | |||
| metadata=metadata) | |||
|
|
|||
| """ | |||
There was a problem hiding this comment.
Thanks! Sorry, I should have proof-read this better.
| # optimized_graph, output_graph, tf_version, | ||
| # signature_def, quantization_dtype_map, weight_shard_size_bytes, | ||
| # initializer_graph_def, initializer_signature_def, | ||
| # resource_ids_maps=resource_ids_maps, metadata=metadata) |
mattsoulanille
force-pushed
the
converter_refactor
branch
from
a620cca
to
7eda00a
Compare
pyu10055
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @Linchenn and @mattsoulanille)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make optimize_graph, extract_weights, and write_artifacts, which do separate things, no longer call each other.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is