[wasm] Add Diag kernel #7277
Merged
[wasm] Add Diag kernel #7277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsoulanille
approved these changes
Jan 17, 2023
Comment on lines
+34
to
+39
| inline void DiagImpl(const T* x_buf, int32_t x_size, T* out_buf) { | ||
| std::fill(out_buf, out_buf + x_size * x_size, 0); | ||
| for (int32_t i = 0; i < x_size; ++i) { | ||
| out_buf[x_size * i + i] = x_buf[i]; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a really nice implementation. For a while, I thought you'd have to do a lot of index calculations to account for diagonals of different dimensions, but that's not the case.
For some k dimensional tensor,
output[i1,..., ik, i1,..., ik] = diagonal[i1, ..., ik]
But the index in the tensor's data array that i1,..., ik corresponds to is some unique number d. Then, we just have
output[d, d] = diagonal[d]
for all d in the input, and this is just
out_buf[x_size * d + d] = x_buf[d]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf.raw_ops.Diagdoes not support boolean as the input, but tfjs-core has op tests for boolean tensors. So wasm kernel still supports boolean tensors.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is