[wasm] Add DenseBincount kernel #7267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyu10055
requested changes
Jan 13, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @chunnienc and @Linchenn)
tfjs-backend-wasm/src/cc/kernels/DenseBincount.cc line 32 at r1 (raw file):
template <typename T> inline void Bincount1D(const int32_t* x_buf, int32_t x_len, int32_t size,
this function could be shared with bincount op, should these two function be separated in a new file?
tfjs-backend-wasm/src/cc/kernels/DenseBincount.cc line 60 at r1 (raw file):
bool binary_output, T* out_buf) { for (int32_t i = 0; i < x_shape_0; ++i) { Bincount1D(x_buf + i * x_shape_1, x_shape_1, size,
good refactoring, nicely done!
I will move them to Bincount.h in the PR adding the bincount op/kernel later. |
pyu10055
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @chunnienc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is