Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bazel BUILD files #7253

Merged
merged 6 commits into from
Jan 10, 2023
Merged

Conversation

chunnienc
Copy link
Collaborator

@chunnienc chunnienc commented Jan 6, 2023

BUILD -> BUILD.bazel to align with other bazel build files in this repo and the style guide

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@chunnienc chunnienc changed the title [wasm] Rename cpp kernel BUILD file Rename bazel BUILD files Jan 6, 2023
@chunnienc chunnienc marked this pull request as ready for review January 6, 2023 21:16
Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we'll probably need to make some internal changes to how we sync these into google3.

@chunnienc chunnienc merged commit 098be65 into tensorflow:master Jan 10, 2023
@chunnienc chunnienc deleted the wasm-cc-build-file branch January 10, 2023 22:49
mattsoulanille added a commit to mattsoulanille/tfjs that referenced this pull request Jan 11, 2023
Fix make-version.js to work with the changes made in tensorflow#7253.
mattsoulanille added a commit that referenced this pull request Jan 11, 2023
Fix make-version.js to work with the changes made in #7253.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants