[converter] add TensorScatterUpdate op to converter and executor #7246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyu10055
changed the title
Linchenn
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
LGTM!
I think after this PR, TFJS could run models with TensorScatterUpdate op. I am curious, does this PR also enables model converter to convert models with TensorScatterUpdate op?
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @mattsoulanille)
qjia7
reviewed
Jan 5, 2023
tfjs-converter/yarn.lock
Outdated
| version "0.1.21" | ||
| resolved "https://registry.yarnpkg.com/@webgpu/types/-/types-0.1.21.tgz#b181202daec30d66ccd67264de23814cfd176d3a" | ||
| integrity sha512-pUrWq3V5PiSGFLeLxoGqReTZmiiXwY3jRkIG5sLLKjyqNxrwm/04b4nw7LSmGWJcKk59XOM/YRTUwOzo4MMlow== | ||
| "@webgpu/[email protected]": |
There was a problem hiding this comment.
Why it's 0.1.16 not 0.1.21? The places we used are all 0.1.21. See https://github.com/tensorflow/tfjs/blob/master/package.json#L29 and https://github.com/tensorflow/tfjs/blob/master/tfjs-core/package.json#L44
|
yes, the op_list json file ensure converter the op is supported. |
Thanks! |
Linchenn
added a commit
to Linchenn/tfjs
that referenced
this pull request
Jan 9, 2023
…sorflow#7246) FEATURE * add TensorScatterUpdate op to converter and executor * update the yarn.lock file Co-authored-by: Linchenn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is
fixed #6709
This the converter side for the op.