Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgpu: support DepthwiseConv2dNativeBackprop kernels #7232

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

xhcao
Copy link
Contributor

@xhcao xhcao commented Jan 4, 2023

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@xhcao xhcao requested review from qjia7 and gyagp January 4, 2023 07:25
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to rename conv_backprop_webgpu_depthwise.ts to conv_backprop_depthwise_webgpu.ts to ensure webgpu as the suffix?

Copy link

@gyagp gyagp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xhcao xhcao force-pushed the DepthwiseConv2dNativeBackpropInput branch from 7c3bbe5 to d86edbf Compare January 5, 2023 06:15
@xhcao xhcao merged commit f768a89 into tensorflow:master Jan 5, 2023
Linchenn pushed a commit to Linchenn/tfjs that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants