[op] added support for TensorScatterUpdate op #7189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linchenn
approved these changes
Dec 20, 2022
| let defaultValuesString = ''; | ||
| if (defaultIsTensor) { | ||
| defaultValuesString = 'coords[0], coords[1]'; | ||
| } |
There was a problem hiding this comment.
Great idea! This bypasses flattening and de-flattening the index.
mattsoulanille
approved these changes
Jan 3, 2023
Comment on lines
45
to
50
| for (size_t k = 0; k < slice_size; ++k) { | ||
| *out_buf_ptr = static_cast<T>(*updates_ptr); | ||
|
|
||
| out_buf_ptr++; | ||
| updates_ptr++; | ||
| } |
There was a problem hiding this comment.
Nit: This is somewhat confusing. Can we use memcpy to copy the slices instead?
Suggested change
| for (size_t k = 0; k < slice_size; ++k) { | |
| *out_buf_ptr = static_cast<T>(*updates_ptr); | |
| out_buf_ptr++; | |
| updates_ptr++; | |
| } | |
| memcpy(out_buf_ptr, updates_ptr, slice_size * dtype_size); | |
| out_buf_ptr += slice_size; | |
| updates_ptr += slice_size; |
It may be possible to further simplify the index calculations as well.
pyu10055
commented
Jan 4, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @mattsoulanille)
tfjs-backend-wasm/src/cc/kernels/TensorScatterUpdate.cc line 50 at r3 (raw file):
memcpy(out_buf_ptr, updates_ptr, slice_size * dtype_size);
out_buf_ptr += slice_size;
updates_ptr += slice_size;
thanks
Linchenn
pushed a commit
to Linchenn/tfjs
that referenced
this pull request
Jan 9, 2023
FEATURE * added support for TensorScatterUpdate op * fix snippet error * fix license year * addressed comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #6709
This is the backend side of implementing TensorScatterUpdate op support across cpu/wasm/webgl/node
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is