Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node's util.types.isUint8Array etc for isTypedArray #7181

Merged
merged 4 commits into from
Dec 16, 2022

Commits on Dec 15, 2022

  1. Use node's util.types.isUint8Array etc for isTypedArray

    isTypedArray is implemented with `instanceof`, which does not work in jest (jestjs/jest#11864). Instead, use node's builtin `util.types.isUint8Array`, `util.types.isFloat32Array`, etc to perform this check.
    
    Fixes tensorflow#7175.
    This may also address tensorflow#7064, but it does not fix the root cause.
    mattsoulanille committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6e68754 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    600e52b View commit details
    Browse the repository at this point in the history
  3. Add a platform_node_test to test isTypedArray on values from new cont…

    …exts
    
    This change also removes platform_node_test from our normal glob of tests that run on the browser and node and places it in its own Bazel target.
    
    Additionally, upgrade @types/node from 12 to 18 to allow importing `node:vm`.
    mattsoulanille committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e5416c2 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Configuration menu
    Copy the full SHA
    e977a17 View commit details
    Browse the repository at this point in the history