Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix diag() example to make is less confusing. #7113

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

robhybrid
Copy link
Contributor

@robhybrid robhybrid commented Nov 26, 2022

Fixed example to make it less confusing.

The second example has the following output:

Tensor
    [[[[1, 0],
       [0, 0],
       [0, 0],
       [0, 0]],

      [[0, 2],
       [0, 0],
       [0, 0],
       [0, 0]]],


     [[[0, 0],
       [3, 0],
       [0, 0],
       [0, 0]],

      [[0, 0],
       [0, 4],
       [0, 0],
       [0, 0]]],


     [[[0, 0],
       [0, 0],
       [5, 0],
       [0, 0]],

      [[0, 0],
       [0, 0],
       [0, 6],
       [0, 0]]],


     [[[0, 0],
       [0, 0],
       [0, 0],
       [6, 0]],

      [[0, 0],
       [0, 0],
       [0, 0],
       [0, 8]]]]

which I found confusing because there's a 6 in the left column (at position [3][0][3][0]), until I noticed the typo, where the 6 is repeated instead of a 7.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@mattsoulanille mattsoulanille merged commit 1073979 into tensorflow:master Nov 29, 2022
Linchenn pushed a commit to Linchenn/tfjs that referenced this pull request Jan 9, 2023
Fixed an example which I found confusing because there's a 6 in the left column (at position [3][0][3][0]), until I noticed the typo, where the 6 is repeated instead of a 7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants