Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check for signature inputs outputs #6978

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

ahmedsabie
Copy link
Contributor

@ahmedsabie ahmedsabie commented Oct 26, 2022

Fixes #6945.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this, the style seems to be bit weird, can you take a look, otherwise LGTM.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @ahmedsabie and @mattsoulanille)


tfjs-converter/src/executor/graph_executor.ts line 648 at r1 (raw file):

    const result: NamedTensorMap = {};
    for (const inputName in inputs) {
      const tensor = this._signature ?.inputs ?.[inputName];

there should be no spaces before the ?

Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the same nit as Ping had about not having spaces in optional chaining.

@kashyap-das
Copy link

When is this going to be released? I am getting this error in production env. Need quick fix here please. Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression: model execution failure
4 participants