Add support for RaggedGather/Range/TensorToTensor conversion #6968
Conversation
ahmedsabie
force-pushed
the
ragged-ttt-conversion
branch
from
0b1c084 to
fb97ed9
Compare
ahmedsabie
changed the title
ahmedsabie
force-pushed
the
ragged-ttt-conversion
branch
from
fb97ed9 to
7d4ec08
Compare
There was a problem hiding this comment.
thank you for adding the ragged ops.
Reviewable status: 0 of 1 approvals obtained (waiting on @ahmedsabie and @lina128)
tfjs-converter/python/tensorflowjs/op_list/ragged.json line 8 at r1 (raw file):
{ "start": 0, "end": -3,
does this mean from the beginning til the 3rd tensor from the end of the input?
which means the paramsDenseValues and outputRaggedRank should be -2 and -1?
tfjs-converter/src/operations/executors/ragged_executor.ts line 3 at r1 (raw file):
/** * @license * Copyright 2021 Google LLC. All Rights Reserved.
2022
tfjs-converter/src/operations/executors/ragged_executor_test.ts line 3 at r1 (raw file):
/** * @license * Copyright 2021 Google LLC. All Rights Reserved.
2022
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @lina128 and @pyu10055)
tfjs-converter/python/tensorflowjs/op_list/ragged.json line 8 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
does this mean from the beginning til the 3rd tensor from the end of the input?
which means the paramsDenseValues and outputRaggedRank should be -2 and -1?
Nice catch, fixed
tfjs-converter/src/operations/executors/ragged_executor.ts line 3 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
2022
Done.
tfjs-converter/src/operations/executors/ragged_executor_test.ts line 3 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
2022
Done.
There was a problem hiding this comment.
Reviewed 3 of 7 files at r1, 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @lina128)
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is