Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource initializer support #6904

Merged
merged 10 commits into from
Oct 7, 2022
Merged

Add resource initializer support #6904

merged 10 commits into from
Oct 7, 2022

Conversation

ahmedsabie
Copy link
Contributor

@ahmedsabie ahmedsabie commented Oct 5, 2022

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@ahmedsabie ahmedsabie marked this pull request as ready for review October 6, 2022 19:37
@ahmedsabie ahmedsabie changed the title Test initializer Add resource initializer support Oct 6, 2022
@ahmedsabie ahmedsabie requested review from lina128 and pyu10055 and removed request for lina128 October 6, 2022 19:39
Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pyu10055)

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained

@pyu10055 pyu10055 merged commit 57e0f21 into master Oct 7, 2022
@pyu10055 pyu10055 deleted the resource-initializer branch October 7, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants