Revert "Add resource initializer support (#6826)" #6900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing regression e2e tests to fail:
1) saved_model_v1_with_hashtable.
#REGRESSION convert_predict webgl {"WEBGL_VERSION":2,"WEBGL_CPU_FORWARD":false,"WEBGL_SIZE_UPLOAD_UNIFORM":0}
Error: Arrays differ: actual[0] = -1, expected[0] = 3.
To reproduce this, use node 16 in e2e/ and run `NIGHTLY=true ./scripts/test-ci.sh`, or, after running that to generate the required files, run `yarn karma start --tags '#REGRESSION'`.
This reverts commit 42dee16.
pyu10055
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @ahmedsabie)
ahmedsabie
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing regression e2e tests to fail:
To reproduce this, use node 16 in e2e/ and run
NIGHTLY=true ./scripts/test-ci.sh, or, after running that to generate the required files, runyarn karma start --tags '#REGRESSION'.This reverts commit 42dee16.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is