Resizing Layer

[dydavidkim]

The branch and commit histories have been cleaned up for the PR.

IMPORT NOTE:
The lower-level op implementation of image resizing-nearest neighbor in TensorFlow.js differs from the implementation of the comparable op in Keras-Python.

While the Python version of the op function always selects the bottom right cell of the sub-matrix to be used as the representative value of that region in the downscaled matrix, the JavaScript implementation defaults to the top left cell of the sub-matrix, and then preferentially shifts to the right side of the sub-matrix in all sub-matrices past the lateral halfway point ( calculated by floor((length-1)/2) ), and the bottom side of the sub-matrix in all sub-matrices past the vertical halfway point, when considering the top-left side of the parent matrix as the origin.

This causes a slight variation in the output values from nearest neighbor downscaling between the Python and JavaScript versions of the code as it currently stands, and the unit tests for the resizing layer has been implemented to reflect this difference in op-function behavior.

Co-authored-by: Adam Lang (@AdamLang96) [email protected]
Co-authored-by: Brian Zheng (@Brianzheng123) [email protected]

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

---

This change is 

[dydavidkim]

@ahmedsabie @mattsoulanille Suggestions have been implemented, requesting review. Thank you!

[mattsoulanille]

This new PR has changes from packages other than tfjs-layers. Is that intentional?

We don't mind PRs having a messy commit history since we squash all commits into a single one when merging. Can we re-open your original PR #6858? This also helps me review your code since I can see changes since my last review.

If you want help with git history (e.g. getting just your changes in the PR), I can reset the resizing branch so it includes only files from tfjs-layers.

[dydavidkim]

This new PR has changes from packages other than tfjs-layers. Is that intentional?

The only changes aside from the tfjs-layers/src/layers/preprocessing should be in tfjs-layers/src/exports-layers.ts for registering the new layer. Any other changes would be from pulling in the new commits made by third parties to the tfjs master repository late last evening and this morning, which made the base branch for this PR outdated.

We don't mind PRs having a messy commit history since we squash all commits into a single one when merging. Can we re-open your original PR #6858? This also helps me review your code since I can see changes since my last review.

If you want help with git history (e.g. getting just your changes in the PR), I can reset the resizing branch so it includes only files from tfjs-layers.

There was a typo made to one of the commits in that branch where the Co-authored-by commit field had incorrectly applied brackets to the github username of a co-author instead of their e-mail address, which was causing the automatic CI tool to fail during checking. I deleted the forks and branches and recreated this one in order to address that issue.

[dydavidkim]

The only changes aside from the tfjs-layers/src/layers/preprocessing should be in tfjs-layers/src/exports-layers.ts for registering the new layer. Any other changes would be from pulling in the new commits made by third parties to the tfjs master repository late last evening and this morning, which made the base branch for this PR outdated.

These are the relevant commits in the pull request:
These commits are pulling in changes to the master branch to silence This branch is out-of-date with the base branch warning in GitHub:
CodeSmithDSMLProjects#41
CodeSmithDSMLProjects#43
Pull 43 is effectively the same as pull 41, I accidentally did it twice because doing it the first time did not make the This branch is out-of-date with the base branch warning go away.

This is the only commit containing the resizing layer changes:
CodeSmithDSMLProjects#42

[mattsoulanille]

LGTM. Thanks!

[mattsoulanille]

@ahmedsabie Please take a look at this PR when you get a chance. Thanks!

[dydavidkim]

@ahmedsabie Hello, the build is failing for an unknown reason, could you check it over if you can?

[mattsoulanille]

@koyykdy Sorry about that build failure. We had changed some cloudbuild permissions on our CI runner, and it broke presubmits. It should be fixed now, though.

[dydavidkim]

@mattsoulanille It seems to be failing still, could you please check what the output from the presubmit failure is? Thank you.

[mattsoulanille]

Looks like it failed to compile:

tfjs-layers/src/exports_layers.ts:1803:17 - error TS6133: 'categoryEncoding' is declared but its value is never read.

1803 export function categoryEncoding(args: CategoryEncodingArgs) {
                     ~~~~~~~~~~~~~~~~

That's strange because usually exporting a value makes typescript not try to check if it's used.

[dydavidkim]

Looks like it failed to compile:

tfjs-layers/src/exports_layers.ts:1803:17 - error TS6133: 'categoryEncoding' is declared but its value is never read.

1803 export function categoryEncoding(args: CategoryEncodingArgs) {
                     ~~~~~~~~~~~~~~~~

That's strange because usually exporting a value makes typescript not try to check if it's used.

This seems to be from the updates brought in by merging in from the master branch, could there be an issue with regards to this?

[dydavidkim]

I attempted to update the branch, and resolved a merge conflict in exports_layers, but the rest of the changes from the main branch merge request might not have gone through.

[mattsoulanille]

Fixed it. Missing a close curly brace.

[mattsoulanille]

The build succeeds now, but the tests still have a compilation error:

tfjs-layers/src/layers/preprocessing/image_resizing_test.ts:113:31 - error TS2345: Argument of type '{ height: number; width: number; interpolation: string; }' is not assignable to parameter of type 'ResizingArgs'.
  Types of property 'interpolation' are incompatible.
    Type 'string' is not assignable to type 'InterpolationFormat'.

113     expect(() => new Resizing(incorrectArgs)).toThrowError(expectedError);
                                  ~~~~~~~~~~~~~

[mattsoulanille]

@ahmedsabie Please take another look when you get a chance. Thanks!

[dydavidkim]

Hello, I do not currently show up under contributors to the tfjs repository on GitHub, is there a way to address this?

[mattsoulanille]

I'm out of office at the moment, so I'll refer you to @Linchenn.

[Linchenn]

I think you are a contributor since you have merged a commit to our default branch. Probably you are not displayed in the contributor list. https://docs.github.com/en/repositories/viewing-activity-and-data-for-your-repository/viewing-a-projects-contributors @koyykdy