CenterCrop Layer #6875
Merged
CenterCrop Layer #6875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Center Crop Preprocessing Layer Co-authored-by: David Kim (@koyykdy) <[email protected]> Brian Zheng (@Brianzheng123) <[email protected]>
|
@mattsoulanille Please take a look whenever you're available. Thanks! |
|
Hi @mattsoulanille, Thanks again for meeting with us this morning! After reviewing the feedback on our last two layers, I am pretty confident we have some repeated mistakes in this one. @koyykdy and I will review this layer and ping you once we have cleaned those up to try and make things easier on your end, so don't worry about reviewing it for now. Thanks, Adam |
|
Thanks for letting me know, @AdamLang96. I'll wait for your ping. |
|
@mattsoulanille I think this is ready for review whenever you're available. Thank you! |
mattsoulanille
requested changes
Oct 4, 2022
Co-authored-by: Matthew Soulanille <[email protected]>
Co-authored-by: Matthew Soulanille <[email protected]>
Merge branch 'centercrop' of https://github.com/CodeSmithDSMLProjects/tfjs into centercrop
Merge branch 'centercrop' of https://github.com/CodeSmithDSMLProjects/tfjs into centercrop
Merge branch 'centercrop' of https://github.com/CodeSmithDSMLProjects/tfjs into centercrop
Merge branch 'centercrop' of https://github.com/AdamLang96/tfjs into centercrop
* refactored centercrop * Update package.json * Update yarn.lock * started fixing layer * finished style changes * added reviewer recs
* refactored centercrop * Update package.json * Update yarn.lock * started fixing layer * finished style changes * added reviewer recs * added semicolon to pass linter
|
@mattsoulanille I updated the layer to reflect your changes. Let me know what you think. Thanks! |
Merge branch 'centercrop' of https://github.com/CodeSmithDSMLProjects/tfjs into centercrop
|
@ahmedsabie Please take a look at this PR. Thanks! |
ahmedsabie
suggested changes
Oct 11, 2022
|
|
||
| return tidy(() => { | ||
| let input: Tensor4D; | ||
| let rank3 = false; |
There was a problem hiding this comment.
Can you rename to isRank3
There was a problem hiding this comment.
@ahmedsabie done!
|
This is failing |
|
@mattsoulanille whoops just fixed it |
|
Thanks! |
ahmedsabie
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
David Kim (@koyykdy) [email protected]
Brian Zheng (@Brianzheng123) [email protected]
This change is