Avoid testing webgl1 in webgl2 layers test #6849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webgl1 was accidentally being tested in webgl2 layers tests. This seems to have been a cause of layers flakiness. Test failures seemed to happen when switching from webgl1 to webgl2.
|
I'm running this test 50 times to find flakiness with |
|
Seed 09887 still fails, so this PR probably doesn't fix the root cause of the flakiness. I'll continue investigating, but this PR should still be merged since we don't want to test webgl1 in |
jinjingforever
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webgl1 was accidentally being tested in webgl2 layers tests. This seems to have been a cause of layers flakiness. Test failures seemed to happen when switching from webgl1 to webgl2.
This PR prevents the webgl1 test env from being used in tfjs-layers unless it is explicitly requested (such as by running
//tfjs-layers:tfjs-layers_webgl1_test).To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is