Fix kernels_to_ops failing to generate kernel2op.json #6823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using `chdir = 'tfjs-converter'` in kernels_to_ops.bzl. Using `chdir` follows the symlink to `tfjs-converter`'s files in the execroot directory (`/usr/local/google/home/msoulanille/.cache/bazel/_bazel_msoulanille/f671279d7efd00bb0451adc485135cc0/execroot/tfjs/tfjs-converter`). Then, when node is started, it doesn't know that it followed a symlink, so when it tries to write to `../bazel-out/.....`, it's no longer looking in the execroot directory and can not find the correct file. Fix this by starting node in the execroot directory instead of in the `tfjs-converter` symlink's directory.
pyu10055
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @lina128)
lina128
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
LGTM
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using
chdir = 'tfjs-converter'in kernels_to_ops.bzl. Usingchdirfollows the symlink totfjs-converter's files in the execroot directory (/usr/local/google/home/msoulanille/.cache/bazel/_bazel_msoulanille/f671279d7efd00bb0451adc485135cc0/execroot/tfjs/tfjs-converter). Then, when node is started, it doesn't know that it followed a symlink, so when it tries to write to../bazel-out/....., it's no longer looking in the execroot directory and can not find the correct path.Fix this by starting node in the execroot directory instead of in the
tfjs-convertersymlink's directory.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is