webgpu: Expand DepthwiseConv2DVec4Program to support any stride #6820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linchenn
approved these changes
Sep 7, 2022
|
|
||
| // Use constant instead of uniform can give better performance. | ||
| for (var wR = 0; wR < ${this.convInfo.filterHeight}; wR = wR + 1) { | ||
| let xR = xRCorner + wR; | ||
| for (var i = 0; i < ${xNumber}; i++) | ||
| if (xR >=0 && xR < uniforms.inDims[0]) |
There was a problem hiding this comment.
Since you moves xR's boundary checks out of readX function, should we also move col's boundary check out of readX function?
There was a problem hiding this comment.
We can move xR's boundary checks out of readX is because we are processing the values in the same row. However, we need to check whether each value is out of boundary for col. So col's boundary check is necessary for each value.
There was a problem hiding this comment.
Yes. I mean, in readX, it may be confusing that we only do boundary check for col while do not for row. Since readX is only used once and it's very straight forward, this LGTM and I was kindly reminding.
Approved.
gyagp
reviewed
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands DepthwiseConv2DVec4Program's capabilities to support any stride size. Meanwhile,
Constraint stride <= 2 to go to this path.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is