-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mistakes #6793
Fix mistakes #6793
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! Thanks for taking the time to improve TensorFlow.js!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 71 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @ivan-pan)
tfjs-core/src/ops/string/string_n_grams.ts
line 54 at r1 (raw file):
* @param padWidth: The number of padding elements to add to each side of each * sequence. Note that padding will never be greater than `nGramWidths`-1 * regardless of this value. If `padWidth`=-1 , then add max(`nGramWidths`)-1
This line exceeds the maximum line length of 80. The easiest way might be to cut off at the comma and add that to the next line. Or the beginning of the sentence.
tfjs-data/src/readers.ts
line 210 at r1 (raw file):
/** * Create an iterator that generates `Tensor`s from webcam video stream. This API
Line exceeds 80
tfjs-data/src/readers.ts
line 246 at r1 (raw file):
/** * Create an iterator that generates frequency-domain spectrogram `Tensor`s from
Line exceeds 80
tfjs-layers/src/exports_layers.ts
line 1499 at r1 (raw file):
* keyword argument of `RNN.call` method. This requires that the `cell.call` * method accepts the same keyword argument `constants`. Such constants * can be used to condition the cell transformation on additional static inputs
Line exceeds 80
It looks like the code fails presubmit due to the length of some of the lines exceeding 80. These are the three that were flagged during the build process. Please check the other lines on which text was added to make sure they don't exceed 80 characters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 71 of 71 files at r1.
Reviewable status: complete! 2 of 1 approvals obtained (waiting on @ivan-pan)
I corrected some mistakes such as
channeLast
(instead ofchannelsLast
). Do check carefully whether I got everything right.Note:
**Input shape:**
is not rendered correctly on the website, where it is shown as “Input shape:*” rather than “Input shape:”.This change is