[op] allow dtype secification for onehot op #6781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinjingforever
approved these changes
Aug 22, 2022
Linchenn
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
LGTM! Thank you!
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @pyu10055)
tfjs-core/src/ops/one_hot.ts line 48 at r1 (raw file):
* @param offValue A number used to fill in the output when the index does * not match the location. *
Could you add a comment here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in this bug, tfjs onehot op only output 'int32' tensor, which does not match to the TF onehot op specification.
This PR will add support for dtype specification for onehot op, will add converter changes in another PR.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is