-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kernel RaggedGather for CPU and WebGL backend #6765
Conversation
c0f2b56
to
7f2e14c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @ahmedsabie and @lina128)
tfjs-backend-cpu/src/kernels/RaggedGather_impl.ts
line 53 at r1 (raw file):
for (let i = 1; i < splits.length; ++i) { if (splits[i - 1] > splits[i]) { throw new Error('Ragged splits must be sorted');
in ascending order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @ahmedsabie and @lina128)
a discussion (no related file):
$ tslint -p tsconfig_tslint.json
/workspace/tfjs-core/src/kernel_names.ts:677:1
ERROR: 677:1 no-consecutive-blank-lines Consecutive blank lines are forbidden
tfjs-core/src/kernel_names.ts
line 676 at r1 (raw file):
rowPartitionTypes: string[]; }
extra empty line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewable status: complete! 2 of 1 approvals obtained (waiting on @ahmedsabie)
7f2e14c
to
3d678da
Compare
00e9884
to
59bc169
Compare
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is