Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernel RaggedGather for CPU and WebGL backend #6765

Merged
merged 6 commits into from
Sep 7, 2022
Merged

Conversation

ahmedsabie
Copy link
Contributor

@ahmedsabie ahmedsabie commented Aug 18, 2022

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @ahmedsabie and @lina128)


tfjs-backend-cpu/src/kernels/RaggedGather_impl.ts line 53 at r1 (raw file):

    for (let i = 1; i < splits.length; ++i) {
      if (splits[i - 1] > splits[i]) {
        throw new Error('Ragged splits must be sorted');

in ascending order.

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @ahmedsabie and @lina128)

a discussion (no related file):
$ tslint -p tsconfig_tslint.json
/workspace/tfjs-core/src/kernel_names.ts:677:1
ERROR: 677:1 no-consecutive-blank-lines Consecutive blank lines are forbidden



tfjs-core/src/kernel_names.ts line 676 at r1 (raw file):

  rowPartitionTypes: string[];
}

extra empty line.

Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @ahmedsabie)

@ahmedsabie ahmedsabie merged commit f8dabdb into master Sep 7, 2022
@ahmedsabie ahmedsabie deleted the ragged-gather branch September 7, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants