Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add exception handling to wasm feature detection #6753

Merged
merged 4 commits into from
Sep 14, 2022
Merged

add exception handling to wasm feature detection #6753

merged 4 commits into from
Sep 14, 2022

Conversation

vladmandic
Copy link
Contributor

@vladmandic vladmandic commented Aug 15, 2022 •
edited by nsthorat
Loading

See issue #6752 for details

This change is Reviewable

@vladmandic vladmandic mentioned this pull request Aug 15, 2022
Closed
@vladmandic
Copy link
Contributor Author

@pyu10055 @jinjingforever can you check this pr to at least get wasm detection back to sanity without throwing exception errors?

@vladmandic
Copy link
Contributor Author

vladmandic commented Sep 13, 2022 •
edited
Loading

@pyu10055 this PR is open for a month now, can you take a look?

mattsoulanille
mattsoulanille approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@mattsoulanille mattsoulanille merged commit 32d2db4 into tensorflow:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinjingforever jinjingforever jinjingforever approved these changes

@mattsoulanille mattsoulanille mattsoulanille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladmandic @mattsoulanille @jinjingforever