-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strengthen frame readiness while testing fromPixels with video element #6751
Conversation
|
Can we further simplify the usage, like "await createAndWaitForVideo(src)"? Then you may hide all the details behind this function. Also for simplicity, we may not need to support multiple sources. |
The unit test removes the video element when it's finished, so for symmetry |
This fixes the error in WebGPU-backed unit tests: OperationError: Failed to execute 'importExternalTexture' on 'GPUDevice': Failed to import texture from video element that doesn't have back resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to browserstack tests, I think it's safe to use a single function. But anyway, it's already a good improvement comparing with exsiting code, so LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @lina128)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @lina128)
This fixes the error in WebGPU-backed unit tests:
OperationError: Failed to execute 'importExternalTexture' on 'GPUDevice': Failed to import texture from video element that doesn't have back resource.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is