-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browserstack benchmark tool] Use stream to write to outfile #6750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job identifying the hard to find bug and fix it! LGTM
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @pyu10055)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: complete! 2 of 1 approvals obtained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @Linchenn)
e2e/benchmarks/browserstack-benchmark/app.js
line 400 at r1 (raw file):
let file; if (cliArgs?.outfile === 'html') { await fs.writeFile('./benchmark_results.js', 'const a = ', 'utf8', err => {
why writing const a =
to the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 2 of 1 approvals obtained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 2 of 1 approvals obtained
e2e/benchmarks/browserstack-benchmark/app.js
line 400 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
why writing
const a =
to the file?
This has been updated to const benchmarkResults =
.
Previously, if
outfile
is set and run benchmarks for multiple models, the output file records the benchmark results only for the last one model, because the program keeps overwriting the output file.This PR:
Ctrl+C
listener to make surefinalize writing function
is always executed.)JSONStream
to append benchmark results whenever receiving results from BrowserStack.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is