-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browserstack benchmark tool] Add a html to present benchmark results #6740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you allow either json or html to be generated?
maybe use a command line flag?
Reviewable status: complete! 1 of 1 approvals obtained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!
Updated outfile
argument. Thank you!
Reviewable status: complete! 1 of 1 approvals obtained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks
Reviewed 1 of 2 files at r2, 1 of 2 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: complete! 2 of 1 approvals obtained
For browserstack benchmark tool, when you run:
node app.js --benchmark='./preconfigured_browser.json' --cloud --outfile
, the program will benchmark all models on devices configured inpreconfigured_browser.json
file and then write down the benchmark results into a json filebenchmark_results.json
, which is too large to be readable.This PR:
benchmark_results.js
), instead of a json file (benchmark_results.json
). Then the benchmark results could be loaded easily to the html file.benchmark_results.js
and renders the benchmark results into a table.Then, whenever complete
node app.js --benchmark='./preconfigured_browser.json' --cloud --outfile
, users no longer need to read benchmark_results.json, and, they could simply openbenchmark_results.html
to see the results.Preview
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is
(For developers only: if want to use typescript to re-write this, could continue on #6741)