[browserstack benchmark tool] Move CodeSnippet from backend to frontend #6738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linchenn
changed the title
|
@pyu10055 Thank you for the suggestion! It is updated and is ready for reviewing. |
pyu10055
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @lina128)
pyu10055
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
thanks!
Reviewable status:
lina128
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Thank you for the refactoring! Looks great!
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves CodeSnippet to benchmark from backend to frontend, and, let the frontend to pass the CodeSnippet to the backend, which allows frontend to customize the CodeSnippet, instead of fix CodeSnippet at backend.
Previously, CodeSnippet is hard-coded in benchmark_model.js at backend, which will be executed by BrowserStack instances.
After this PR, we could add UI elements to enable users to edit codeSnippet (at frontend).
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is