Setup optimization target deices/browsers #6722
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained
e2e/benchmarks/browserstack-benchmark/preconfigured_browser.json line 33 at r1 (raw file):
"device": null }, "Windows_7_1": {
I don't know why it originally has this target for win7. Should we remove it?
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @Linchenn, @mattsoulanille, and @pyu10055)
e2e/benchmarks/browserstack-benchmark/preconfigured_browser.json line 33 at r1 (raw file):
Previously, Linchenn wrote…
I don't know why it originally has this target for win7. Should we remove it?
I think this is to capture the lowest os version that we support. We should add lowest os version test for ios and android too. Can be in a separate PR.
There was a problem hiding this comment.
LGTM
Reviewed 1 of 1 files at r1.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status:
e2e/benchmarks/browserstack-benchmark/index.js line 40 at r3 (raw file):
base: 'BrowserStack', browser: 'chrome', browser_version: '15.3',
is 15.3 the latest version of chrome? Or it is for safari? the latest of chrome should b 103+
e2e/benchmarks/browserstack-benchmark/preconfigured_browser.json line 33 at r1 (raw file):
Previously, lina128 (Na Li) wrote…
I think this is to capture the lowest os version that we support. We should add lowest os version test for ios and android too. Can be in a separate PR.
The firefox version is also very low, the latest is around 103+
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
e2e/benchmarks/browserstack-benchmark/index.js line 40 at r3 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
is
15.3the latest version of chrome? Or it is for safari? the latest of chrome should b 103+
Updated.
e2e/benchmarks/browserstack-benchmark/preconfigured_browser.json line 33 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
The firefox version is also very low, the latest is around 103+
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
e2e/benchmarks/browserstack-benchmark/preconfigured_browser.json line 33 at r1 (raw file):
Previously, Linchenn wrote…
Done.
Thank you Na, Matt and Ping. Just synced with Ping, I will separate this list into two lists in a separate PR: one list contains lowest os version/devices that we support (this will be included in nightly benchmark), while another list contains the most popular devices/browsers (will be included in both nightly benchmark and benchmark for optimization)
This PR updates the list of the combinations of devices and browsers. The list currently is used only for our nightly-benchmark, and I will use the devices/browsers in this list as WebGL optimization targets.
Specifically, the list will have 6 combinations on desktop/laptop and 17 combinations on mobile:
Windows
1.1 Win 11: Chrome, Firefox, Edge
1.2 Win 7: Firefox
Mac - Monterey: Safari, Chrome
Andriod
iOS
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is