Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tfjs-converter] Revert "fix protobuf version to 3.20.0 (#6612)" #6721

Merged
merged 3 commits into from
Aug 5, 2022

Conversation

pyu10055
Copy link
Collaborator

@pyu10055 pyu10055 commented Aug 4, 2022

Removed the version locking on protobuf pip, given the nightly is not failing any more. fixes #6698

nightly test link
This reverts commit 438917f.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pyu10055 pyu10055 merged commit ad7bfe5 into master Aug 5, 2022
@pyu10055 pyu10055 deleted the protobuf_pip branch August 5, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accidental drop of Python 3.6 support? Colab incompatibility due to hard-pinned protobuf version.
3 participants